cc @chevdor

Thanks for the PR @Akagi201.
I wanted to have the dockerfile as independant as possible but your change will likely make it more maintainable.

Not sure we need the ./init.sh (nor its content) at all actually. So please hold on before merging until I am done with a few tests.

@chevdor I post this PR to let the docker build process be the same as the manually build process. I think it is important for consistency.

When build manually, just run

./init.sh
./build.sh
cargo build

so the Dockerfile should be the same process.

I have tested it and you may check it twice.

What I am trying to say is that ./init.sh and ./build.sh are not required in the build process.
You can have a look at #463 where I removed them entirely. It makes the image smaller and faster to build while having also less moving parts.

I agree with two stage docker build. It is also good for isolating the source code and binary. And I wrote one for my own use. https://github.com/Akagi201/dockerfile/blob/master/polkadot/Dockerfile

I am not sure the need for the init.sh and build.sh script. If they are not required, you may close this PR.

What is the size of the image you get in the end with your 2 stages image?

@Akagi201 Thanks again for this PR, I will close it as agreed since the scripts are definitely not required.